Fix missing template apply button in Redmine 6.0 #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Redmine 6.0, the template apply button is not displayed, making it unclickable.
This issue occurs because the
display
style for elements with the.icon
class has changed toinline-flex
in Redmine 6.0.https://github.com/redmine/redmine/blob/0abf7105dab7c6558a26cdcc28c6770ad89649d0/app/assets/stylesheets/application.css#L1728
This change affects all icon-only elements in this plugin.
To resolve this, I modified to replace the
.icon
class with the existing.icon-only
class for all icon elements.I verified all icon-only images display correctly.
![result-template](https://private-user-images.githubusercontent.com/739339/384804494-1fd1c2e6-633b-41eb-ba14-2559419264ed.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTk3ODcsIm5iZiI6MTczODg1OTQ4NywicGF0aCI6Ii83MzkzMzkvMzg0ODA0NDk0LTFmZDFjMmU2LTYzM2ItNDFlYi1iYTE0LTI1NTk0MTkyNjRlZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNlQxNjMxMjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05Mzc3NGI1OWZlM2VmMTdiM2MxNDczYjhlNWUyMGYzYjY1Yjg0MmNlYzg2NzBlYjVjZDljMjM5Zjc4ZjJkOTVmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.FCCYp8Vx7m6nYiOC-uvlREfUoY-masTmDcpd-VtXRvo)
Results for other pages
Note (the template in the 2nd line is a global note template):
![result-notes](https://private-user-images.githubusercontent.com/739339/384805221-9824d5ad-19a3-4e9d-be27-3bf00f5818be.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTk3ODcsIm5iZiI6MTczODg1OTQ4NywicGF0aCI6Ii83MzkzMzkvMzg0ODA1MjIxLTk4MjRkNWFkLTE5YTMtNGU5ZC1iZTI3LTNiZjAwZjU4MThiZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNlQxNjMxMjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xZjkxYjZjODZiYzUwYTM5ODAxODVjYWE4MzQzM2Q0ODIxYzc5ZjdjODZiOTU0OWRmZDQ5MmI5N2Q5ZDMzZDY2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.HV75nyfWRm5S0oKflqAZ8h538jiNpkZirlBL0x8Su1Y)
Add global template/note form:
![image](https://private-user-images.githubusercontent.com/739339/384806466-2fcbcbdb-19d7-4f6f-b986-979b670efd9d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTk3ODcsIm5iZiI6MTczODg1OTQ4NywicGF0aCI6Ii83MzkzMzkvMzg0ODA2NDY2LTJmY2JjYmRiLTE5ZDctNGY2Zi1iOTg2LTk3OWI2NzBlZmQ5ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNlQxNjMxMjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01OWU4NzYyMTBmOGIzYjI5OGI2OGU5MDBhMGM1Y2JhMjJjOTBlMmFmMWYzZDIxNWZhOGFhOTZkZjZlMDU5YWE1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.FkcLCOTSA52sB9K4Srl-Di33hHsf0onTWtIsKEvmP58)
Plugin configuration form:
![image](https://private-user-images.githubusercontent.com/739339/384807413-f73cd3a0-1957-457b-ad68-2c1a2a5df74b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTk3ODcsIm5iZiI6MTczODg1OTQ4NywicGF0aCI6Ii83MzkzMzkvMzg0ODA3NDEzLWY3M2NkM2EwLTE5NTctNDU3Yi1hZDY4LTJjMWEyYTVkZjc0Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNlQxNjMxMjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MjExMTZhMjlhODFiNDBjY2M4YmY3MTgxMTQzZTVlNGY1NTIxNjgzODZhY2NiOTllODdjN2E5YmUyZTc5MjRkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.1ryNfG84sHXjm3gd8EzBJZkDlpjNajNBcGqDVFtTdRg)
Environments: