Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare changelog for release #428

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Prepare changelog for release #428

merged 4 commits into from
Jun 18, 2024

Conversation

xvrh
Copy link
Collaborator

@xvrh xvrh commented Jun 18, 2024

Preparing the changelog for release.
Do you agree @isoos ?

@xvrh xvrh requested a review from isoos June 18, 2024 12:43
@xvrh
Copy link
Collaborator Author

xvrh commented Jun 18, 2024

Also changing whereNotNull to nonNulls to appease the analyzer (deprecation warning from package:collection).
But this requires we restraint the sdk contraints to ^3.0.0

@isoos
Copy link
Contributor

isoos commented Jun 18, 2024

But this requires we restraint the sdk contraints to ^3.0.0

I think that's fine, plenty of time has passed since 3.0 came out.

@xvrh xvrh merged commit fcace78 into agilord:master Jun 18, 2024
2 checks passed
@xvrh xvrh deleted the xha/prepare_release branch June 18, 2024 13:59
@VerTiGoEtrex
Copy link
Contributor

Looks like shared_aws_api was never published with the changes I added in #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isoos isoos isoos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xvrh @isoos @VerTiGoEtrex