fix: parent groups appended to all attributes #19 (#20)

agoda-com · May 30, 2024 · 5ecb4b6 · 5ecb4b6
1 parent 88a8c91
commit 5ecb4b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/otelslog/conv.go b/otelslog/conv.go
@@ -39,6 +39,7 @@ func otelAttribute(attr slog.Attr) []attribute.KeyValue {
 		group := attr.Value.Group()
 		var result []attribute.KeyValue
 		for _, v := range group {
+			v.Key = attr.Key + "." + v.Key
 			result = append(result, otelAttribute(v)...)
 		}
 		return result

diff --git a/otelslog/otel_handler_test.go b/otelslog/otel_handler_test.go
@@ -27,7 +27,8 @@ func newResource() *resource.Resource {
 }
 
 func doSomething(ctx context.Context) {
-	slog.InfoContext(ctx, "hello slog", slog.String("myKey", "myValue"))
+	slog.InfoContext(ctx, "hello slog", slog.String("myKey", "myValue"),
+		slog.Group("myGroup", slog.String("groupKey", "groupValue")))
 }
 
 func TestNewOtelHandler(t *testing.T) {
@@ -60,5 +61,5 @@ func TestNewOtelHandler(t *testing.T) {
 	actual := buf.String()
 
 	assert.Contains(t, actual, "INFO hello slog [scopeInfo: github.com/agoda-com/otelslog:0.0.1] {host.name=")
-	assert.Contains(t, actual, "service.name=otelslog-example, service.version=1.0.0, first=value1, group1.second=value2, group1.group2.myKey=myValue}")
+	assert.Contains(t, actual, "service.name=otelslog-example, service.version=1.0.0, first=value1, group1.second=value2, group1.group2.myKey=myValue, group1.group2.myGroup.groupKey=groupValue}")
 }