-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[atable] Fix atable modal attach to cell #220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…also detects edges and adjusts position to prevent overflow
Coverage Report for ./atable
File Coverage
|
Coverage Report for ./aform
File Coverage
|
Alchez
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Alchez @agritheory Here is a branch I came up with to hopefully solve #214 . I have this working by switching the modal to use absolute positioning, so it will move along with the scrolling without needing any scroll listeners (I ran into the same scroll listener issues in Histoire).
I also included the modal's ability to detect edges of its container (atable in this instance). Usually the modal will appear left along with the cell and below it, but if the modal would overflow off the right edge, it will instead adjust to butt up against the right edge of the container. If it would overflow below, it instead appears above the cell (the bottom 2 or three cells will use this behavior).
I tried to encapsulate most of this modal edge-detecting logic within ATableModal itself while keeping it fairly agnostic as to what its container or content will be.
I found it was easier to get positioning by using offsetLeft/Top to get the element position in its container (useElementSize was only giving me the position in the viewport). I felt like I was frantically duct taping this together while working on it, so there is probably room for improvement.