Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project] add strict null checks to improve logic #234

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

Alchez
Copy link
Collaborator

@Alchez Alchez commented Jan 9, 2025

This will also help us migrate to the latest xstate version in the future, which strongly recommends setting this TS flag.

@Alchez Alchez requested a review from agritheory January 9, 2025 11:10
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Coverage Report for ./beam

Status Category Percentage Covered / Total
🔴 Lines 5.3% (🎯 70%) 7 / 132
🔴 Statements 5.59% (🎯 70%) 8 / 143
🔴 Functions 2.43% (🎯 70%) 1 / 41
🔴 Branches 0% (🎯 70%) 0 / 81
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
beam/src/composables/mqtt.ts 0% 0% 0% 0% 12-44
Unchanged Files
beam/src/components/ActionFooter.vue 0% 100% 0% 0% 12-5
beam/src/components/BeamArrow.vue 0% 0% 100% 0% 2-4
beam/src/components/BeamDayDivider.vue 0% 0% 0% 0% 17-2
beam/src/components/BeamFilter.vue 0% 0% 0% 0% 18-9
beam/src/components/BeamFilterOption.vue 0% 0% 0% 0% 41-21
beam/src/components/BeamMetadata.vue 0% 0% 0% 0% 2-1
beam/src/components/BeamModal.vue 0% 0% 0% 0% 3-5
beam/src/components/BeamModalOutlet.vue 0% 100% 100% 0% 2
beam/src/components/BeamProgress.vue 0% 0% 0% 0% 22-3
beam/src/components/Confirm.vue 0% 0% 0% 0% 4-1
beam/src/components/ItemCheck.vue 0% 0% 0% 0% 9-3
beam/src/components/ItemCount.vue 0% 0% 0% 0% 20-1
beam/src/components/ListAnchor.vue 0% 100% 100% 0% 1
beam/src/components/ListItem.vue 0% 0% 0% 0% 27-15
beam/src/components/ListView.vue 0% 0% 0% 0% 29-2
beam/src/components/Navbar.vue 0% 0% 0% 0% 13-null
beam/src/components/ScanInput.vue 88.88% 100% 50% 87.5% 23
beam/src/components/SplitColumn.vue 0% 0% 100% 0% 5-8
Generated in workflow #533 for commit 5371d0d by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Coverage Report for ./atable

Status Category Percentage Covered / Total
🟢 Lines 70.46% (🎯 70%) 167 / 237
🟢 Statements 71.2% (🎯 70%) 178 / 250
🟢 Functions 81.63% (🎯 70%) 40 / 49
🔴 Branches 49.45% (🎯 70%) 90 / 182
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
atable/src/components/ACell.vue 90.56% 62.5% 100% 90.38% 100, 123-126, 156, 164-166
atable/src/components/ARow.vue 64.28% 56.25% 75% 58.33% 51-65, 17
atable/src/stores/table.ts 74% 50% 84.21% 73.91% 39-40, 53, 84-85, 107-111, 127, 134, 138-149, 176, 184-185, 191
Unchanged Files
atable/src/utils.ts 100% 100% 100% 100%
atable/src/components/AExpansionRow.vue 0% 0% 0% 0% 33-3
atable/src/components/ATable.vue 59.25% 37.5% 90.9% 58.49% 112-116, 126-154
atable/src/components/ATableHeader.vue 100% 57.14% 100% 100%
atable/src/components/ATableModal.vue 90% 75% 50% 90% 49
Generated in workflow #533 for commit 5371d0d by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Coverage Report for ./aform

Status Category Percentage Covered / Total
🟢 Lines 85.95% (🎯 70%) 202 / 235
🟢 Statements 85.41% (🎯 70%) 205 / 240
🟢 Functions 77.77% (🎯 70%) 42 / 54
🔴 Branches 68.46% (🎯 70%) 76 / 111
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
aform/src/directives/mask.ts 84.09% 59.09% 100% 83.72% 46-47, 54, 69, 91, 131, 136
Unchanged Files
aform/src/components/AForm.vue 90% 40% 85.71% 90% 40-41
aform/src/components/base/CollapseButton.vue 100% 100% 100% 100%
aform/src/components/form/ACheckbox.vue 100% 100% 100% 100%
aform/src/components/form/AComboBox.vue 0% 0% 100% 0% 2-1
aform/src/components/form/ADate.vue 66.66% 66.66% 33.33% 66.66% 32, 42, 4
aform/src/components/form/ADatePicker.vue 95% 81.81% 92.85% 94.82% 68, 94, 29
aform/src/components/form/ADropdown.vue 91.48% 76.92% 84.61% 91.48% 55, 84-85, 93
aform/src/components/form/AFieldset.vue 88.88% 100% 50% 88.88% 8
aform/src/components/form/AFileAttach.vue 0% 0% 0% 0% 26-17
aform/src/components/form/ANumericInput.vue 100% 100% 100% 100%
aform/src/components/form/ATextInput.vue 100% 100% 100% 100%
aform/src/components/utilities/Login.vue 87.5% 88.88% 100% 87.5% 76-78
Generated in workflow #533 for commit 5371d0d by the Vitest Coverage Report Action

@Alchez Alchez merged commit 0de3505 into development Jan 9, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant