-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[atable] fix for modal positioning #235
Conversation
Coverage Report for ./atable
File Coverage
|
@crabinak I think the logic for rendering modals for the last few cells has maybe regressed. Here's what I see in the ATable default story |
@Alchez I added a line to include the Y position of the window scroll when calculating the maximum height. Let me know if this fixes it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crabinak This looks good. But I've added a commit based on some typing warnings in the IDE. Can you please check out the change locally and verify that the behaviour hasn't changed?
@Alchez It is still working fine. Thanks! |
@Alchez @agritheory related to the issue we were having with the amodal not positioning correctly. This fix changes the modal position to fixed while still auto-detecting edges (so it doesn't get cropped off-screen). The position of the modal uses the position of the cell instead of offset positioning, so it shouldn't matter what the parent is doing (I used some test wrapping divs as parents to ATable and gave them various positioning).
Let me know if this resolves that weird positioning issue that was occurring.
Example image: The modal right aligns with the page since it would otherwise overflow and get cropped.
