-
Notifications
You must be signed in to change notification settings - Fork 114
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This applies a quickfix solution for interesection protocols, opting to fully ignore runtime checks of `__orig_bases__` and `__weakref__` attributes. This has the effect of turning some false positives into true negatives, but it also leaves some false negatives. To make that clear, xfail test cases are added for the resulting false negatives. A more robust fix would perhaps be to introduce recursive behavior whenever a `__orig_bases__` attribute is found, making the type checker check each inherited protocol individually. The resulting "top level" intersection type would also need individual checking though, as it can add required attributes on its own.
- Loading branch information
1 parent
2c035b3
commit 06aa3eb
Showing
3 changed files
with
63 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters