-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pass
to removed blocks of code
#386
Add pass
to removed blocks of code
#386
Conversation
You need to fix the linting error and add a note to the changelog. What's with the gitignore change? |
3a9389d
to
083eec9
Compare
Fixed
Added
I was getting a lot of |
083eec9
to
6812bd2
Compare
Solves agronholm#352 more generally.
c28e159
to
0d14083
Compare
for more information, see https://pre-commit.ci
The test you added seems to already pass in EDIT: Never mind, I was on a 3.8 virtualenv so the test didn't get run. |
Thanks! |
@agronholm, I opened python/cpython#108521 where they pointed out that maybe we should only be filling in |
Sure. |
Solves #352 more generally.
We saw this in exception handlers but I think that it can manifest itself on any construct that has an expected child block.
We could potentially even totally remove the statements in the test as they are no-op.