-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creating ref cycles #408
Merged
Merged
Commits on Sep 23, 2023
-
By storing previously raised exceptions inside a local, this code created ref cycles that kept all locals in all calling stack frames alive. This is because exceptions hold references to their tracebacks, which hold references to the relevant frames, which holds a reference to the local errors dict that holds references to the exceptions. See https://peps.python.org/pep-0344/#open-issue-garbage-collection and https://peps.python.org/pep-3110/#rationale This breaks the cycle by deleting the local when we raise, so frames are destroyed by the normal reference counting mechanism. This fixes some resource exhaustion issues I encountered at work.
Configuration menu - View commit details
-
Copy full SHA for f165e56 - Browse repository at this point
Copy the full SHA f165e56View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 8b5d2c6 - Browse repository at this point
Copy the full SHA 8b5d2c6View commit details
Commits on Jan 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7577df5 - Browse repository at this point
Copy the full SHA 7577df5View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa32213 - Browse repository at this point
Copy the full SHA aa32213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e31b88 - Browse repository at this point
Copy the full SHA 3e31b88View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdb173e - Browse repository at this point
Copy the full SHA fdb173eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf38460 - Browse repository at this point
Copy the full SHA cf38460View commit details
Commits on Jan 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4802b3a - Browse repository at this point
Copy the full SHA 4802b3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8afdea8 - Browse repository at this point
Copy the full SHA 8afdea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17ffe9c - Browse repository at this point
Copy the full SHA 17ffe9cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.