Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower bound typing-extensions >= 4.6 #473

Closed

Conversation

ymerkli
Copy link

@ymerkli ymerkli commented Jul 10, 2024

Changes

Fixes #472

typeguard uses typing_extensions.Buffer, which was only added to typing_extenions>=4.6.0, see here.

This PR adds typing_extenions>=4.6.0 as a requirement.

Checklist

  • If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
    these instructions.
  • Updating the changelog

@coveralls
Copy link

Coverage Status

coverage: 94.139%. remained the same
when pulling 76af066 on ymerkli:ymerkli/lower-bound-typing-extensions
into 016f813 on agronholm:master.

@agronholm
Copy link
Owner

Typeguard already has a higher typing_extensions requirement here. Besides, your PR adds it to build requirements, why?

@agronholm agronholm closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing_extensions.Buffer requires typing-extensions>=4.6
3 participants