-
Notifications
You must be signed in to change notification settings - Fork 82
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build full data image before displaying the image instead of displayi…
…ng an image that can be a chunk of the full image in some case
- Loading branch information
Zombitch
committed
May 25, 2018
1 parent
e43cf6d
commit ecbf668
Showing
1 changed file
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend you to change code with Buffer, for instance:
for receiving images without color corruption.
Thank you for simple solution with ffmpeg.
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for your purpose! Does this solution helps to avoid blank frames? If it so, your commit is very helpful.
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if it so, can you make a PR?)
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, test of data.length removes blinks and Buffer removes image corruption,
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR - you mean some feedback ?
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, пришли, пожалуйста пул реквест со своими исправлениями.Я с удовольствием смерджу. Не забудь себя вписать в соавторы в package.json
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Seikon you've done a lot of work, thank you. Can you add yourself as the contributor to the package.json ?
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Seikon also I thought that we can handle frames with buffer object, to prevent converting it to string, an I right?
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thank you, I'll try to do this, but I also haven't possibility to test it
@igkvl can you help us?)
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have an old OS. I just tried to start an explosive mixture x64 IIS8+iisnode+node+socket.io, it's not working, because iisnode.
But I found error with Buffer:
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where? Buffer API changed a lot of time since node 0.8 version. I'll try to fix this warning, I've written this code a long time ago.
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning was shown on windows with iis+iisnode
ecbf668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at issnode, seems that they have node.js version >=6.0. Fixed it in package.json. Thanks.