Merge pull request #106 from ahmadsoe/overriding-methods

Prefer overriding didInsertElement and willDestroyElement
ahmadsoe · Dec 19, 2016 · db0b2ec · db0b2ec
2 parents 1d59e20 + 2be1525
commit db0b2ec
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/addon/components/high-charts.js b/addon/components/high-charts.js
@@ -9,7 +9,6 @@ const {
   computed,
   get,
   set,
-  on,
   run,
   $
 } = Ember;
@@ -124,14 +123,18 @@ export default Component.extend({
     }
   },
 
-  _renderChart: on('didInsertElement', function() {
+  didInsertElement() {
+    this._super(...arguments);
+
     this.drawAfterRender();
     setDefaultHighChartOptions(getOwner(this));
-  }),
+  },
+
+  willDestroyElement() {
+    this._super(...arguments);
 
-  _destroyChart: on('willDestroyElement', function() {
     if (get(this, 'chart')) {
       get(this, 'chart').destroy();
     }
-  })
+  }
 });