Add version flag #76
Merged
Add version flag #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
force-pushed
the
add-release-flag
branch
from
32c4fc2
to
f50c4b2
Compare
lucacome
force-pushed
the
add-release-flag
branch
from
f50c4b2
to
dfb1db9
Compare
|
@ahmetb any thoughts on this? |
lucacome
force-pushed
the
add-release-flag
branch
from
dfb1db9
to
62fa6e2
Compare
ahmetb
approved these changes
Jul 25, 2024
main.go
Outdated
| commitHash, commitTime, dirtyBuild := getBuildInfo() | ||
| arch := fmt.Sprintf("%v/%v", runtime.GOOS, runtime.GOARCH) | ||
|
|
||
| fmt.Printf("gen-crd-api-reference-docs version=%s commit=%s date=%s dirty=%v arch=%s go=%v\n", version, commitHash, commitTime, dirtyBuild, arch, runtime.Version()) |
There was a problem hiding this comment.
Should we move this inside the if?
There was a problem hiding this comment.
I was thinking that it would be useful to always print the version at startup, but happy to move it.
There was a problem hiding this comment.
I forgot how much output the program prints. If it's very little, it might get annoying.
There was a problem hiding this comment.
it would be something like
❯ gen-crd-api-reference-docs -config site/config/api/config.json -template-dir site/config/api -out-file site/content/reference/api.md -api-dir "github.com/nginxinc/nginx-gateway-fabric/apis"
gen-crd-api-reference-docs version=0.3.0-SNAPSHOT-62fa6e2 commit=62fa6e27a07bac0cf553ec35ab52736d3a58a5e6 date=2024-07-24T22:16:31Z dirty=false arch=darwin/arm64 go=go1.22.5
I0724 19:01:55.984928 60449 main.go:144] parsing go packages in directory github.com/nginxinc/nginx-gateway-fabric/apis
I0724 19:02:00.058290 60449 main.go:246] using package=github.com/nginxinc/nginx-gateway-fabric/apis/v1alpha1
I0724 19:02:00.070753 60449 main.go:182] written to site/content/reference/api.md
There was a problem hiding this comment.
Ehh looks a bit wonky especially since we use klog for the rest of the output. Let's move inside "if" IMO if you don't mind. 🤞
Signed-off-by: Luca Comellini <[email protected]>
lucacome
force-pushed
the
add-release-flag
branch
from
62fa6e2
to
d24cff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-versionflag.Closes #25