Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: decouple header extraction from file access #7

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

dkogut1996
Copy link
Contributor

No description provided.

@dkogut1996 dkogut1996 requested a review from biw June 24, 2024 20:17
Copy link
Member

@biw biw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Makes things a lot faster!

Before (node 20):

PASS test/index.test.ts (18.78 s)
  gguf
    ✓ Llama-2-7b-Chat-GGUF  (4106 ms)
    ✓ Nous-Capybara-7B-v1.9-GGUF (3834 ms)
    ✓ Xwin-MLewd-7B-V0.2-GGUF (3929 ms)
    ✓ EveryoneLLM-7b.gguf (3734 ms)

After (node 20):

PASS test/index.test.ts (5.639 s)
  gguf
    ✓ Llama-2-7b-Chat-GGUF (888 ms)
    ✓ Nous-Capybara-7B-v1.9-GGUF (408 ms)
    ✓ Xwin-MLewd-7B-V0.2-GGUF (192 ms)
    ✓ EveryoneLLM-7b.gguf (265 ms)
    ✓ L3-8B-Stheno-v3.3-32K.Q8_0.gguf (736 ms)

@biw biw merged commit 1e57fdb into main Jun 24, 2024
3 checks passed
@dkogut1996 dkogut1996 deleted the dk/efficient-file-reading branch June 24, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants