new: atddiff tool #358
Merged
new: atddiff tool #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It mostly works but incorrect locations are reported for parametrized types.
mjambon
requested review from
rgrinberg,
Khady,
zindel and
cyberhuman
as code owners
|
to do: avoid infinite looping on recursive type definitions |
|
Another important thing to do is honor the |
the error messages.
|
ship it! |
some comparison e.g. 'type t = a' and 'type t = b' will result in treating types 'a' and 'b' as the same type.
- object field renaming with '<json name="...">' - enum/variant renaming with '<json name="...">' - JSON maps with '(string * _) list <json repr="object">'
|
This is feature-complete for a first release unless I forgot something. I'll update the documentation in another PR while the opam release is in progress. |
This was referenced Oct 15, 2023
mjambon
added a commit
to mjambon/opam-repository
that referenced
this pull request
Oct 16, 2023
CHANGES: * atdts: Stop compiler errors on generated typescript (ahrefs/atd#348) * atdts: Don't fail on `wrap` constructs (ahrefs/atd#353) * atdcat: New option `-remove-wraps` which pretty-prints the type definitions without `wrap` constructs (ahrefs/atd#353) * atdd: Add `dlang` backend to generate D code from ATD definitions (ahrefs/atd#349) * new tool: atddiff. Compares two versions of an ATD file and reports possible incompatibilities in the JSON data. Atddiff ships as part of the `atd` package together with `atdcat` (ahrefs/atd#352, ahrefs/atd#358)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: * atdts: Stop compiler errors on generated typescript (ahrefs/atd#348) * atdts: Don't fail on `wrap` constructs (ahrefs/atd#353) * atdcat: New option `-remove-wraps` which pretty-prints the type definitions without `wrap` constructs (ahrefs/atd#353) * atdd: Add `dlang` backend to generate D code from ATD definitions (ahrefs/atd#349) * new tool: atddiff. Compares two versions of an ATD file and reports possible incompatibilities in the JSON data. Atddiff ships as part of the `atd` package together with `atdcat` (ahrefs/atd#352, ahrefs/atd#358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #352
I still need to review the test results more carefully and add tests.For now, the output is text. We can add JSON output in another PR (see #360).PR checklist
CHANGES.mdis up-to-date