fixed the access token thing etc #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinahedenius
commented
May 26, 2020
elinahedenius
commented
- The old api thing didn't let you get content from it anymore without having an access token (api requires token now #1), so I switched it out for another one
- made the download not stop when one url is invalid
- also wanted to try making a pull request and you're my friend so it's not as scary
…ken and made the thing still download the other images even if one url is incorrect
ahstro
requested changes
Jun 22, 2020
|
|
||
| return { name: name, url: image.url } | ||
| return image; |
There was a problem hiding this comment.
Nice! However, now that we're not doing any magic in the function, would you mind rewriting it as an arrow function? 😇
Edit: Oh, I just remebered, consider reading up on how to write nice commit messages. You'll love it yourself, and other open source projects will be very grateful 😉
| https.get(imageUrl, (res) => { | ||
| res.pipe(coverFile) | ||
| console.log("Done!"); |
| } else { | ||
| return false | ||
| console.error(str + " does not look like a valid spotify url, so won't be downloaded."); | ||
| return false; |
| for(x in apiUrls){ | ||
| // Commence callback hell | ||
| https.get(apiUrls[x], getJson); | ||
| } |
There was a problem hiding this comment.
Not a huge fan of building arrays imperatively like this. Original idea was that startFetching would be used for individual urls (feels like it would make it more versatile if wanting to extend the program), although I'd be open to doing it differently. How did your thoughts go around this? 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.