Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Update default CAS configuration keys in portal-backend service #1

Open
wants to merge 1 commit into
base: aio-ai4eu
Choose a base branch
from

Conversation

mxm-tr
Copy link

@mxm-tr mxm-tr commented Jun 25, 2021

Context

In the Sign in Angular component of the portal frontend, the configured login URL parameter is given by a the following function:
getDockerProperty("portal.feature.cas.login"), called in src/main/webapp/app/header/sign-in.component.js

This JS function builds and executes the following API request to the portal-be:
https:///api/generic/getProperty?propertyName=portal.feature.cas.login

Which gets the value of the requested key from the application configuration.

Change

This change makes the CAS URIs configurable, with the configuration keys located in the expected location.

@mwelss-fhg
Copy link

Hi Maxim,

very good idea, just one question: does the portal run fine after a fresh installation, if the CAS variables stay empty?

Best,
Martin

@mxm-tr
Copy link
Author

mxm-tr commented Aug 13, 2021

@mwelss-fhg, I haven't had the chance to test all the features but at least the default parameters are set with the expected keys in the portal backend configuration, with the address of the CAS server of the Linux Foundation:

https://github.com/acumos/portal-marketplace/blob/79622dc81386821f8bd15be4f5b783e115f28ef3/acumos-portal-be/application.properties#L181
https://github.com/acumos/portal-marketplace/blob/79622dc81386821f8bd15be4f5b783e115f28ef3/acumos-portal-be/application.properties#L144

Even though the config keys are correct, an issue still remains with the CAS ServiceTicket validation: https://jira.acumos.org/browse/ACUMOS-4334

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants