optimize goal_count (callgrind ir/call : 816 -> 126)

aibasel · Jan 12, 2025 · 8008590 · 8008590
1 parent c7d6a4d
commit 8008590
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/search/heuristics/goal_count_heuristic.cc b/src/search/heuristics/goal_count_heuristic.cc
@@ -15,15 +15,23 @@ GoalCountHeuristic::GoalCountHeuristic(
     if (log.is_at_least_normal()) {
         log << "Initializing goal count heuristic..." << endl;
     }
+    goals.reserve(task_proxy.get_goals().size());
+    for (FactProxy goal : task_proxy.get_goals()) {
+	int var = goal.get_variable().get_id();
+	int val = goal.get_value();
+	goals.push_back({var,val});
+    }
 }
 
 int GoalCountHeuristic::compute_heuristic(const State &ancestor_state) {
     State state = convert_ancestor_state(ancestor_state);
     int unsatisfied_goal_count = 0;
-
-    for (FactProxy goal : task_proxy.get_goals()) {
-        const VariableProxy var = goal.get_variable();
-        if (state[var] != goal) {
+    state.unpack();
+    const vector<int> &unpacked_state = state.get_unpacked_values();
+    for (const auto& it : goals) {
+	const int& var = it.first;
+	const int& val = it.second;
+        if (unpacked_state[var] != val) {
             ++unsatisfied_goal_count;
         }
     }

diff --git a/src/search/heuristics/goal_count_heuristic.h b/src/search/heuristics/goal_count_heuristic.h
@@ -5,6 +5,7 @@
 
 namespace goal_count_heuristic {
 class GoalCountHeuristic : public Heuristic {
+    std::vector<std::pair<int,int>> goals;
 protected:
     virtual int compute_heuristic(const State &ancestor_state) override;
 public: