Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add list directories action #24

Closed
wants to merge 1 commit into from

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Aug 22, 2023

Description

A first small action that can be used to list directories with certain files. For example it can be used in HC to get the collections:

- uses: aica-technology/.github/.github/actions/list-directories-containing-files@feature/list-directories
  id: list
  with:
    files: "(bake.hcl)"

or to get all packages in a repo (for changelog checks):

- uses: aica-technology/.github/.github/actions/list-directories-containing-files@feature/list-directories
  id: list
  with:
    files: "(package.xml CMakeLists.txt)"

Review guidelines

Estimated Time of Review: 5 minutes

@LouisBrunner
Copy link
Contributor

I think we need an action like this but I was waiting for the real packaging system to come in before we roll it out. I am not sure why we need an extra listing for changelog checks though? Using bake.hcl you already know each package and can check if it has a changelog file and add to it there? Not sure we should have 2 ways to identify what a package is.

  files: "(package.xml CMakeLists.txt)"

Might be better to use "package.xml,CMakeLists.txt" as this is how we do it everywhere else and it seems odd to use bash syntax there?

@domire8
Copy link
Member Author

domire8 commented Aug 22, 2023

Using bake.hcl you already know each package and can check if it has a changelog file and add to it there? Not sure we should have 2 ways to identify what a package is.

I was thinking that we'd have a CHANGELOG per ROS package. There is not one bake.hcl per ROS package, only per collection

@LouisBrunner
Copy link
Contributor

Using bake.hcl you already know each package and can check if it has a changelog file and add to it there? Not sure we should have 2 ways to identify what a package is.

I was thinking that we'd have a CHANGELOG per ROS package. There is not one bake.hcl per ROS package, only per collection

But how does that translate to a changelog for the whole collection? We only tag the collections (as this is what gets released) not individual ROS packages?

@domire8
Copy link
Member Author

domire8 commented Aug 22, 2023

Yeah okay that's true my bad 👍 However, for all other repos, you'd need to go look for each package separately (components, dynamic state engine)

@domire8
Copy link
Member Author

domire8 commented Aug 25, 2023

Let's put this on hold for now, I did not have the right mindset at the beginning of the week

@domire8
Copy link
Member Author

domire8 commented Sep 19, 2023

This is currently not needed, I will close this without merge

@domire8 domire8 closed this Sep 19, 2023
@domire8 domire8 deleted the feature/list-directories branch September 19, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants