resolving comments

aidenybai · Feb 10, 2025 · a3db0ae · a3db0ae
1 parent 940410a
commit a3db0ae
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/packages/scan/src/cli.mts b/packages/scan/src/cli.mts
@@ -298,7 +298,6 @@ const init = async () => {
 
       await page.evaluate(() => {
         if (typeof globalThis.reactScan !== 'function') return;
-        // @ts-expect-error - TODO: fix this
         globalThis.reactScan({ report: true });
       });
 

diff --git a/packages/scan/src/web/views/inspector/components-tree/index.tsx b/packages/scan/src/web/views/inspector/components-tree/index.tsx
@@ -233,6 +233,19 @@ const useNodeHighlighting = (
   }, [node.label, node.nodeId, node.fiber, searchValue]);
 };
 
+const formatTime = (time: number) => {
+  if (time > 0) {
+    if (time < 0.1 - Number.EPSILON) {
+      return '< 0.1';
+    }
+    if (time < 1000) {
+      return Number(time.toFixed(1)).toString();
+    }
+    return `${(time / 1000).toFixed(1)}k`;
+  }
+  return '0';
+};
+
 const TreeNodeItem = ({
   node,
   nodeIndex,
@@ -273,19 +286,6 @@ const TreeNodeItem = ({
     if (!node.renderData) return null;
     const { selfTime, totalTime, renderCount } = node.renderData;
 
-    const formatTime = (time: number) => {
-      if (time > 0) {
-        if (time < 0.1 - Number.EPSILON) {
-          return '< 0.1';
-        }
-        if (time < 1000) {
-          return Number(time.toFixed(1)).toString();
-        }
-        return `${(time / 1000).toFixed(1)}k`;
-      }
-      return '0';
-    };
-
     if (!renderCount) {
       return null
     };