feat: kitchen sink 2.0 #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
lxsmnsyc
commented
Jan 25, 2025
|
|
||
| import './styles.css'; | ||
|
|
||
|
|
||
| Store.isInIframe.value = false; |
There was a problem hiding this comment.
react-scan doesn't work inside iframes, this enables it
lxsmnsyc
commented
Jan 25, 2025
There was a problem hiding this comment.
I just copied this from my forgetti example: https://github.com/lxsmnsyc/forgetti/tree/main/examples/react/src
lxsmnsyc
commented
Jan 25, 2025
| const examples: Example[] = [ | ||
| { title: 'Sierpinski Triangle', url: '/?example=sierpinski' }, | ||
| { title: 'Todo List', url: '/?example=todo-list' }, | ||
| ]; |
There was a problem hiding this comment.
A little bit manual. When you add a new app in the examples/, this needs to be reflected.
?example query needs to match the folder name
lxsmnsyc
commented
Jan 25, 2025
| @@ -4,7 +4,6 @@ | |||
| "scripts": { | |||
| "build": "WORKSPACE_BUILD=true node scripts/workspace.mjs build", | |||
| "postbuild": "node scripts/version-warning.mjs", | |||
| "postinstall": "pnpm build", | |||
There was a problem hiding this comment.
A bit annoying.
fyi: pnpm no longer runs this by default, https://github.com/pnpm/pnpm/releases/tag/v10.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kitchen-sink/src/examplesexamplesandkitchen-sink