Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote port forwarding #178

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −6
Open

Add remote port forwarding #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a107048
add remote port forwarding
superstar54 May 6, 2023
1b44d0e
update md
superstar54 May 6, 2023
f9faa7c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions aiidalab_launch/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@

ssh {user}@{hostname} -NfL {port}:localhost:{port}

If you visit the remote machine through a jump server, you run (replace the J_IP with the jump server IP):

ssh -J {user}@J_IP {user}@{hostname} -NfL {port}:localhost:{port}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that possible to get the J_IP if you are already ssh to the remote through SSH, this command is suppose to be copy-paste and run.



on your local computer, then open AiiDAlab on your local computer at

{url}
Expand Down Expand Up @@ -87,7 +92,7 @@ def callback(ctx, param, value): # noqa: U100
)(cmd)


@click.group(context_settings={"help_option_names": ["-h", "--help"]})
@click.group()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase the branch? I guess you force push and override the new changes.

@click.option(
"-v",
"--verbose",
Expand Down Expand Up @@ -415,11 +420,9 @@ async def _async_start(
raise click.ClickException(f"Unknown error occurred: {error}")
else:
if wait:
logging_level = logging.getLogger().getEffectiveLevel()
try:
with spinner("Waiting for AiiDAlab instance to get ready..."):
if logging_level == logging.DEBUG:
echo_logs = asyncio.create_task(instance.echo_logs())
echo_logs = asyncio.create_task(instance.echo_logs())
await asyncio.wait_for(instance.wait_for_services(), timeout=wait)
except asyncio.TimeoutError:
raise click.ClickException(
Expand All @@ -436,8 +439,7 @@ async def _async_start(
else:
LOGGER.debug("AiiDAlab instance ready.")
finally:
if logging_level == logging.DEBUG:
echo_logs.cancel()
echo_logs.cancel()

LOGGER.debug("Preparing startup message.")
msg_startup = (
Expand Down
7 changes: 7 additions & 0 deletions ssh-forward.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,11 @@ This can be easily achieved by creating an SSH tunnel and forwarding the AiiDAla
$ ssh [email protected] -NfL 8888:localhost:8888
```

If you visit the remote machine through a jump server, you run (replace the J_IP with the jump server IP):

```console
$ ssh -J {user}@J_IP {user}@{hostname} -NfL {port}:localhost:{port}
```


5. Finally, open AiiDAlab in the browser of your local machine via the URL provided earlier, something like: http://localhost:8888/?token=74647d5fe0...