Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the key is still valid, don't generate it by click #9

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

If the key is still valid, don't generate it by click #9

wants to merge 1 commit into from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 16, 2023

No description provided.

@unkcpz unkcpz requested a review from yakutovicha October 16, 2023 15:14
@unkcpz
Copy link
Member Author

unkcpz commented Oct 16, 2023 •
edited
Loading

This PR can go first before #6 .

yakutovicha
yakutovicha reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doing this? What if it is 6pm, and I am about to go home. The key is valid for 2 hours, and I want to keep AiiDA running for the night. What do I do?

@unkcpz
Copy link
Member Author

unkcpz commented Oct 18, 2023

Good point, I was thinking about it but forgot it during the implementation. Do you think it is okay that I use _parse_validity_time and only do this if the valid time is greater than let's say 23.5h? Just to avoid keep on click the update will run out of 5 times limitation per day.

@yakutovicha
Copy link
Member

Maybe add a switch "Allow valid keys update" and enable it by default. Or, better add a confirmation dialog "Are you sure? The key is still valid."

@unkcpz
Copy link
Member Author

unkcpz commented Oct 20, 2023

dialog "Are you sure? The key is still valid."

Good idea, since this is not an urgent feature, I want to with some react magic as an experiment.

@unkcpz unkcpz marked this pull request as draft October 20, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakutovicha yakutovicha yakutovicha left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unkcpz @yakutovicha