Group bands by angular momentum by default #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndresOrtegaGuerrero
approved these changes
Jan 13, 2025
|
Need to check more closely, but I think it may be an issue with an assumption in the test. |
I guess a backwards compatibility issue. Python 3.9 + AiiDA v2.3 tests failing (2.6 passing). if plot_tag != "total":
if not pdos.nscf.output_parameters.get("spin_orbit_calculation"):
data_dict = _update_pdos_labels(data_dict)Something about the use of |
edan-bainglass
force-pushed
the
angular-momentum-grouping
branch
from
a0049e1 to
cff3ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by Giovanni