-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly tests adjust run test_memory_leak in test move high_link to nightly #6701
Nightly tests adjust run test_memory_leak in test move high_link to nightly #6701
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
==========================================
+ Coverage 77.99% 78.00% +0.01%
==========================================
Files 563 563
Lines 41766 41766
==========================================
+ Hits 32573 32574 +1
+ Misses 9193 9192 -1 ☔ View full report in Codecov by Sentry. |
75f7d58
to
6be28ed
Compare
6be28ed
to
4f488ce
Compare
@@ -262,6 +264,7 @@ def test_complex_workflow_graph_links(aiida_profile_clean, tmp_path, aiida_local | |||
assert set(export_set) == set(import_set) | |||
|
|||
|
|||
@pytest.mark.nightly | |||
def test_complex_workflow_graph_export_sets(aiida_profile, tmp_path, aiida_localhost_factory): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although not failed with pytest-xdist, I think this kind of DB test should run with aiida_profile_clean
to start from a clean profile. If it can be moved to nightly then the slow down because of aiida_profile_clean
is less noticeable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any timing for this? Currently, you move it to nightly, but are not using aiida_profile_clean
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I think this one also need to use aiida_profile_clean
.
a09fbf7
to
2d3b125
Compare
2d3b125
to
2f4b5fa
Compare
7f82256
to
54ad788
Compare
btw: To fix the lockfile issue, you could have just run |
Didn't know, I update with |
No worries, I am also new to this lockfile business. I'll try to find some time next week and write up our experience so far on wiki (and perhaps move the wiki article to an internal doc in the repo as we discussed). |
That would be super nice. uv is a great stuff, I switch all package management when working with engine part to uv, now every change is expected and easy to switch between python versions. I can also contribute to dev wiki on how to set and test in different python versions. |
aiida_computer_ssh
fixture set safe_interval -> 1.0stest_memary_leak
test for SSH timeout because the long intervals of 4 steps.I make safe_interval short for pytest ssh computer fixture, so it can used for running memory leak test not just in nightly.
@GeigerJ2 you may already have it in your PR. the calcjob run in this test can reproduce the 4 times transport request which you may interested to have a look.