Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly tests adjust run test_memory_leak in test move high_link to nightly #6701

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 11, 2025

I make safe_interval short for pytest ssh computer fixture, so it can used for running memory leak test not just in nightly.

@GeigerJ2 you may already have it in your PR. the calcjob run in this test can reproduce the 4 times transport request which you may interested to have a look.

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (7a460c0) to head (83625ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6701      +/-   ##
==========================================
+ Coverage   77.99%   78.00%   +0.01%     
==========================================
  Files         563      563              
  Lines       41766    41766              
==========================================
+ Hits        32573    32574       +1     
+ Misses       9193     9192       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz changed the title Run memory leak test for computer SSH Nightly tests adjust run test_memory_leak in test move high_link to nightly Jan 12, 2025
@unkcpz unkcpz force-pushed the memory-leak-test-ssh-no-nightly branch from 75f7d58 to 6be28ed Compare January 12, 2025 11:51
@unkcpz unkcpz force-pushed the memory-leak-test-ssh-no-nightly branch from 6be28ed to 4f488ce Compare January 13, 2025 11:51
@@ -262,6 +264,7 @@ def test_complex_workflow_graph_links(aiida_profile_clean, tmp_path, aiida_local
assert set(export_set) == set(import_set)


@pytest.mark.nightly
def test_complex_workflow_graph_export_sets(aiida_profile, tmp_path, aiida_localhost_factory):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although not failed with pytest-xdist, I think this kind of DB test should run with aiida_profile_clean to start from a clean profile. If it can be moved to nightly then the slow down because of aiida_profile_clean is less noticeable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any timing for this? Currently, you move it to nightly, but are not using aiida_profile_clean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think this one also need to use aiida_profile_clean.

@unkcpz unkcpz force-pushed the memory-leak-test-ssh-no-nightly branch 4 times, most recently from a09fbf7 to 2d3b125 Compare January 15, 2025 10:37
@unkcpz unkcpz force-pushed the memory-leak-test-ssh-no-nightly branch from 2d3b125 to 2f4b5fa Compare January 15, 2025 20:04
@unkcpz unkcpz requested a review from agoscinski as a code owner January 16, 2025 10:47
@unkcpz unkcpz force-pushed the memory-leak-test-ssh-no-nightly branch from 7f82256 to 54ad788 Compare January 16, 2025 10:50
@danielhollas
Copy link
Collaborator

btw: To fix the lockfile issue, you could have just run uv lock. This would reduce the diff here, since it would not upgrade the diff packages, it would only remove the aiida-core version from the lockfile.

@unkcpz
Copy link
Member Author

unkcpz commented Jan 16, 2025

btw: To fix the lockfile issue, you could have just run uv lock. This would reduce the diff here, since it would not upgrade the diff packages, it would only remove the aiida-core version from the lockfile.

Didn't know, I update with --upgrade in #6698 and merged. Sorry.

@unkcpz unkcpz merged commit b356950 into aiidateam:main Jan 16, 2025
10 checks passed
@unkcpz unkcpz deleted the memory-leak-test-ssh-no-nightly branch January 16, 2025 12:33
@danielhollas
Copy link
Collaborator

Didn't know, I update with --upgrade in #6698 and merged. Sorry.

No worries, I am also new to this lockfile business. I'll try to find some time next week and write up our experience so far on wiki (and perhaps move the wiki article to an internal doc in the repo as we discussed).

@unkcpz
Copy link
Member Author

unkcpz commented Jan 16, 2025

I'll try to find some time next week and write up our experience so far on wiki (and perhaps move the wiki article to an internal doc in the repo as we discussed).

That would be super nice. uv is a great stuff, I switch all package management when working with engine part to uv, now every change is expected and easy to switch between python versions. I can also contribute to dev wiki on how to set and test in different python versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants