-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install cp2k from conda #170
Conversation
- Install cp2k from conda-forge - Bump aiida-core base container to 1.6.9
for more information, see https://pre-commit.ci
b932725
to
e4d8da4
Compare
e4d8da4
to
5aaa580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
USER aiida | ||
|
||
RUN mamba create --yes -c conda-forge -n cp2k cp2k=9.1 && mamba clean --all -f -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you install the latest version of CP2K?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next step would be to test against multiple versions of cp2k, to make sure the plugin is compatible with all of them.
I am sure the new ones will have issues, so to not blow up the PR I decided to make the change as small as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, would it be possible to also put ARM builds there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, would it be possible to also put ARM builds there?
CP2K supports ARM with Linux and macOS. This is also tested on the Dashboard. However, those tests sill use the old Makefile build system. So, adding ARM to the Conda package should be doable, but might require ironing out some CMake issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CP2K supports ARM with Linux and macOS. This is also tested on the Dashboard. However, those tests sill use the old Makefile build system. So, adding ARM to the Conda package should be doable, but might require ironing out some CMake issues.
It is not urgent, but if it could be done at some point - this would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sasha showed me the working version for AMD64
The conda installation comes with sirius library support.