Remove cargo2nix #668
Merged
Remove cargo2nix #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes from cargo2nix to just use `buildRustPackage`, which does not generate itermediate crate derivations for the build. This means that we lose dependency caching (for CI as well), but on the other hand it becomes much more cacheable for people that actually use Nix to add the dependencies.
|
Looks good to me but I don't really know nix so I'll wait for someone else to review. |
rvcas
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make @KtorZ happy.
The whole idea is to avoid generating lots of intermediate derivations, so we can cache the whole build output, and require a special build step that can break the build every now and then.
The trade-off is that some dependencies might need more rebuild than usual, but the increase in reliability should more than cover it.