feat: introduce WireMock for testing #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascheman
reviewed
Oct 11, 2024
| @@ -21,6 +21,9 @@ dependencies { | |||
|
|
|||
| testImplementation platform("org.codehaus.groovy:groovy-bom:${GroovySystem.version}") | |||
| testImplementation 'org.codehaus.groovy:groovy-xml' | |||
|
|
|||
| testImplementation 'org.wiremock.integrations.testcontainers:wiremock-testcontainers-module:1.0-alpha-14' | |||
| testImplementation "org.testcontainers:junit-jupiter:1.20.2" | |||
There was a problem hiding this comment.
Could you please put the versions into the gradle/libs.versions.toml file?
| import java.lang.reflect.Field | ||
| import java.lang.reflect.Proxy | ||
|
|
||
|
|
There was a problem hiding this comment.
Please do not make more than one new line behind a new block (I know this is not consequently done over all of the repository).
| def setup() { | ||
| myConfig = new Configuration() | ||
| brokenHttpLinksChecker = new BrokenHttpLinksChecker( myConfig ) | ||
|
|
||
| collector = new SingleCheckResults() | ||
| } | ||
|
|
||
|
|
||
| /** executed once after all specs are executed **/ | ||
| def cleanupSpec() { |
There was a problem hiding this comment.
Just a remark: This should have been part of the previous commit (but I am fine if it stays here).
...anityCheck-core/src/test/java/org/aim42/htmlsanitycheck/test/dns/CustomHostNameResolver.java
Show resolved
Hide resolved
...Check-core/src/test/groovy/org/aim42/htmlsanitycheck/check/BrokenHttpLinksCheckerSpec.groovy
Show resolved
Hide resolved
ascheman
reviewed
Oct 11, 2024
| @@ -131,7 +180,7 @@ class BrokenHttpLinksCheckerSpec extends Specification { | |||
| //@Ignore("test currently breaks. see issue-219") | |||
There was a problem hiding this comment.
Perhaps you could also remove the comment here?
|
I just see there are some |
RehanChalana
force-pushed
the
use_mocks_for_testing
branch
from
8fd4076
to
d9d0194
Compare
RehanChalana
force-pushed
the
use_mocks_for_testing
branch
from
d9d0194
to
6aab113
Compare
|
Merge post-poned due to PavanMudigonda/jacoco-reporter#68 |
- Added WireMockContainer to BrokenHttpLinksCheckerSpec for mocking HTTP responses. - progress towards fixing aim42#331 - Configured WireMock to use mappings.json for predefined request-response mappings.
…ests - progress towards fixing aim42#331
…stnames - progress towards fixing aim42#331
…mHostNameResolver - fixes aim42#331 - Updated all URLs in test cases to use WireMock with Testcontainers. - Integrated CustomHostNameResolver to ensure tests run without internet. - Updated `mappings.json` with mappings for all test URLs. - Remove test for recognizing internet connectivity.
RehanChalana
force-pushed
the
use_mocks_for_testing
branch
from
6aab113
to
58b87db
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.