Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Relax numpy version upper bound #3182

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Jul 8, 2024

Would it be possible to merge and release this? aim is the last Python package preventing us from upgrading to numpy==2.0.0

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@judahrand judahrand force-pushed the main branch 3 times, most recently from 749bff3 to 7ecd7ac Compare July 8, 2024 14:16
@mihran113 mihran113 changed the title [feat] relax numpy version upper bound [feat] Relax numpy version upper bound Jul 10, 2024
@mihran113 mihran113 self-requested a review July 10, 2024 10:56
Copy link
Contributor

@mihran113 mihran113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @judahrand! Thank a lot for opening the PR. Everything looks good. 🎉
There's a fail in unit tests not related to your changes, I'll fix that later in a separate PR.

@mihran113 mihran113 merged commit 215196d into aimhubio:main Jul 10, 2024
2 of 3 checks passed
@mihran113
Copy link
Contributor

Hey @judahrand! The new release of aim has been shipped (3.23.0). It includes the changes made in this PR. Let me know if everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants