[AIP-134] Add rationale on update_mask being optional
#1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add text explaining why `update_mask` must be OPTIONAL over REQUIRED.
jskeet
reviewed
Aug 12, 2024
| @@ -103,6 +103,9 @@ message UpdateBookRequest { | |||
| - The field **must** be optional, and the service **must** treat an omitted | |||
| field mask as an implied field mask equivalent to all fields that are | |||
| populated (have a non-empty value). | |||
| - Rationale is that omission of `update_mask` is equivalent on it being | |||
There was a problem hiding this comment.
Rather than include this here, I'd suggest adding a rationale section separately.
There was a problem hiding this comment.
Indeed, and I'd take a glance at the guidance in AIP-8 for this section:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add text explaining why
update_maskmust be OPTIONAL over REQUIRED.