-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: using powershell instead of cmd /C #708
Conversation
An approach to resolve issue #707 |
Similar comment on #549. |
@@ -21,7 +21,7 @@ func (e *Engine) startCmd(cmd string) (*exec.Cmd, io.ReadCloser, io.ReadCloser, | |||
if !strings.Contains(cmd, ".exe") { | |||
e.runnerLog("CMD will not recognize non .exe file for execution, path: %s", cmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should replace CMD
with powershell
here.
every windows os has powershell? |
As mentioned in #549, Windows PowerShell has been included by default since Windows 10 version 1607, which was released 2016, so the majority of the users should be fine. |
can we check first in the user host contains |
I check the Minimum Requirements for go compiler, and go 1.21 and later only supports Windows 10 and higher, which came with PowerShell 5.0 preinstalled. Since we're using go 1.23, I think it should be acceptable to replace CMD with PowerShell. |
Make sense. |
No description provided.