Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS example app for EpoxyCore #163

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

calda
Copy link
Member

@calda calda commented Mar 7, 2024

Change summary

This PR adds a macOS example app for EpoxyCore. This reflects our usage of EpoxyCore macOS support in Lottie.

Before #162, the example app looks like this:

Screenshot 2024-03-07 at 9 13 07 AM

Currently on master / after #162, the example app no longer looks correct and hits an infinite loop hang on startup:

Screenshot 2024-03-07 at 9 14 12 AM

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

  • Wrote automated tests
  • Built and ran on the iOS simulator
  • Built and ran on a device


// MARK: - LayoutDemoView

struct LayoutDemoView: View {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches this demo test case we have in the Lottie repo, just using an AppKit NSImageView instead of the AppKit LottieAnimationView.

Copy link
Contributor

@brynbodayle brynbodayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants