Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly pass through offset from AnimatedGridRows/Columns #1769

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: correctly pass through offset from AnimatedGridRows/Columns #1769

merged 1 commit into from
Nov 17, 2023

Conversation

henrinormak
Copy link
Contributor

🐛 Bug Fix

  • Correctly pass through offset in AnimatedGridRows
  • Correctly pass through offset in AnimatedGridColumns

williaster
williaster approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @henrinormak 🙏 ! lgtm, will get this released asap.

@williaster williaster merged commit 33064d3 into airbnb:master Nov 17, 2023
2 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version v3.5.1 of the packages modified 🎉

Onxi95 pushed a commit to Onxi95/visx that referenced this pull request Nov 21, 2023
@henrinormak @Onxi95
fix: correctly map through offset from AnimatedGridRows/Columns (airb…
df4c4d1 
…nb#1769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🐛 bug patch-release @visx/react-spring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrinormak @williaster