Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for elasticsearch output #10

Closed
wants to merge 6 commits into from
Closed

Support for elasticsearch output #10

wants to merge 6 commits into from

Conversation

janstarke
Copy link
Contributor

Hey guys,

I started to implement an elasticsearch output, which makes it easier to correlate a lot of information. Could you please have a look at my proof-of-concept? At the moment, shimcache and regtime are working.

Unfortunately, I needed to modify the interface of PluginResult, which would require to adapt all plugins :-( But I think, the interface is more nice now

Regards, Jan

@simsor simsor mentioned this pull request Jan 20, 2021
4 tasks
@simsor
Copy link
Member

simsor commented Jan 20, 2021

Hello, and thanks for the PR!

I understand the need behind this change, but I wonder if pushing to a database should really be RegRippy's job. I think that a third-party script could handle the communication with the database, it would just need a better machine output than the mactime format to do its job.

I am not against adding a new display function to PluginResult, but how about a display_json instead? This way, users could get a better output format for further processing and it would be much more generic than ElasticSearch. I developed this idea in #11, feel free to add your thoughts.

I really like the changes you made to PluginResult.__init__ tough, is there any way you could open a PR with only these changes please?

@janstarke janstarke closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants