Skip to content

Commit

Permalink
Added a task in study for issue 252
Browse files Browse the repository at this point in the history
  • Loading branch information
c8y3 committed Sep 6, 2023
1 parent e5070a1 commit 05e7f08
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion notes/study_for_issue_252.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ Look all `User.query.filter`, transform `User.user ==` into `User.user.ilike`).

Implementation tasks performed:
* in `app.datamgmt.manage.manage_users_db` split method `get_user(user_id, key)` in to `get_user and get_user_by_mail(user_email)`
* grouped most calls to `User.query.filter*` into `app.datamgmt.manage.manage_users_db`
* grouped most calls to `User.query.*` into `app.datamgmt.manage.manage_users_db`
* checked test scenarios

Implementation questions to:
* couldn't the `User.query.filter` with entities [here](https://github.com/dfir-iris/iris-web/blob/v2.3.2/source/app/blueprints/case/case_timeline_routes.py#L752) simply be replaced by a call to `get_user` followed by an access to field `name` of the result?
Expand Down

0 comments on commit 05e7f08

Please sign in to comment.