Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Rbroughan/jschmidt/s3v2/rc 9 but with parallelism at 1 #51050

Closed

Conversation

tryangul
Copy link
Contributor

This PR + Testing to see if setting parallelism to 1 does anything

@tryangul tryangul requested review from a team as code owners January 11, 2025 00:08
Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 0:12am

@edgao
Copy link
Contributor

edgao commented Jan 11, 2025

is this intentionally editing java-connector instead of bulk-connector.gradle? (that's the old connector plugin, which I'm pretty sure has no power here)

@edgao
Copy link
Contributor

edgao commented Jan 11, 2025

I'm fairly certain you want this instead

airbyte/build.gradle

Lines 183 to 189 in 09132c7

if (concurrency.isInteger() && (concurrency as int) > 0) {
// Define a fixed number of threads when the property is set to a positive integer.
systemProperty 'junit.jupiter.execution.parallel.config.fixed.parallelism', concurrency
} else {
// Otherwise let JUnit manage the concurrency dynamically.
systemProperty 'junit.jupiter.execution.parallel.config.strategy', 'dynamic'
}

(or just edit the destination-s3/gradle.properties? I'm probably missing context, but that option is supposed to work)

@tryangul
Copy link
Contributor Author

@edgao Sorry you're getting pinged for these, but these are just test permutations.

I will likely try the other permutations. If there's a good way to not notify you but get CI to run my tests, lmk.

If you dare to read further I'll explain myself.

I realize this is in the 'wrong spot'—but I'm kicking this off for reasons:

@tryangul tryangul added work-in-progress Do not merge, this is a work in progress. and removed area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Jan 11, 2025
@tryangul tryangul changed the title Rbroughan/jschmidt/s3v2/rc 9 but with parallelism at 1 [TEST] Rbroughan/jschmidt/s3v2/rc 9 but with parallelism at 1 Jan 11, 2025
@edgao
Copy link
Contributor

edgao commented Jan 11, 2025

weird. That feels like a coincidence, destination-s3 doesn't even apply the airbyte-java-connector plugin...

(nw about the ping - I thought we used to run tests on draft PRs, but I guess not anymore)

@tryangul tryangul closed this Jan 13, 2025
@tryangul tryangul deleted the rbroughan/jschmidt/s3v2/rc-9-but-with-parallelism-at-1 branch January 13, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connectors/destination/s3 work-in-progress Do not merge, this is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants