Destination S3 Data Lake: fix+document temporal types #53176
+47
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edgao
commented
Feb 4, 2025
edgao
commented
- update the basicTypes test case to exercise non-UTC offset
- update iceberg to handle timetz correctly (i.e. adjust to UTC)
- iceberg already does this implicitly for timestamptz
- update iceberg tests
- add documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
edgao
force-pushed
the
edgao/iceberg_types
branch
from
4354362 to
3716dad
Compare
|
|
edgao
changed the base branch from
edgao/iceberg_schema_evolution_error_message
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.