Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-omnisend contribution from steven-luabase #53208

Conversation

steven-luabase
Copy link
Contributor

@steven-luabase steven-luabase commented Feb 6, 2025

What

This PR updates source Omnisend (source-omnisend).

The contributor provided the following description of the change:

Updated schemas for all streams as some results returned by the Omnisend API were failing schema validation. Used the Connector Builder for this PR.

Reviewer checklist

  • Resolve any merge conflicts and validate file diffs (make sure the PR only includes changes intended by the contributor)
  • After reviewing the changes, run the bump-version Airbyte-CI command locally to update the version of the connector according to the versioning guidelines. Add breakingChanges to metadata if necessary.
  • Ensure connector docs are up to date with any changes
  • Run /format-fix to resolve any formatting errors
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

Copy link

vercel bot commented Feb 6, 2025

@steven-luabase is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out about the dynamic schema so we can ship the contribution.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out about the dynamic schema so we can ship the contribution.

@steven-luabase
Copy link
Contributor Author

Got it, @marcosmarxm just made those changes let me know how they look to you

@marcosmarxm
Copy link
Member

marcosmarxm commented Feb 7, 2025

/bump-version type="minor" changelog="update schemas and make dynamic"

Bump Version job started... Check job output.

✅ Changes applied successfully. (0620de8)

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:54pm

@marcosmarxm marcosmarxm enabled auto-merge (squash) February 10, 2025 13:53
@marcosmarxm marcosmarxm merged commit 6f72367 into airbytehq:master Feb 10, 2025
27 checks passed
yardencarmeli pushed a commit that referenced this pull request Feb 10, 2025
Co-authored-by: Marcos Marx <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/omnisend
Projects
Development

Successfully merging this pull request may close these issues.

4 participants