[source pg] Fix issue #6857 #53649
Open
[source pg] Fix issue #6857 #53649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
burakku
force-pushed
the
wenqi-bug-fix
branch
from
039a66b to
79628a7
Compare
burakku
force-pushed
the
wenqi-bug-fix
branch
from
79628a7 to
b3f1783
Compare
burakku
force-pushed
the
wenqi-bug-fix
branch
from
b3f1783 to
6fdb7d1
Compare
burakku
force-pushed
the
wenqi-bug-fix
branch
from
6fdb7d1 to
26db658
Compare
burakku
force-pushed
the
wenqi-bug-fix
branch
from
26db658 to
e76ac9d
Compare
burakku
force-pushed
the
wenqi-bug-fix
branch
from
e76ac9d to
3e51c18
Compare
burakku
force-pushed
the
wenqi-bug-fix
branch
from
3e51c18 to
dabb46e
Compare
burakku
force-pushed
the
wenqi-bug-fix
branch
from
dabb46e to
6e3863e
Compare
burakku
force-pushed
the
wenqi-bug-fix
branch
from
6e3863e to
be764ac
Compare
|
/bump-version type=patch changelog="Fix issue that column default value did not get converted"
|
octavia-squidington-iii
added
the
area/documentation
burakku
force-pushed
the
wenqi-bug-fix
branch
from
640ffed to
0dcf30b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We have issue in #6857 about the data conversion error
Currently in our data type converter for debezium, we check if the value is null, if it is and column is non-nullable, we return the default value directly without conversion. Otherwise, return null as is.
Two issues here:
we should convert the default value as well then return it
it appears that we found null value in non-nullable column
How
This PR check if the column is nullable, if so, return null as is
if not, we feed the default value to conversion logic and return the result.
Review guide
User Impact
Can this PR be safely reverted and rolled back?