Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Michelson instructions and add new ones #10

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

m-kus
Copy link
Contributor

@m-kus m-kus commented Jan 17, 2023

Here are some changes made in order to comply with the latest language spec:

  • DIP n <= optional nat argument comes first
  • FAILWITH <= typo
  • UNPACK additionally expects type argument
  • CAST instruction also expects type argument (it's kinda deprecated, but still used in some tests)
  • SUB_MUTEZ instruction added
  • SELF and CONTRACT can have field annotation (entrypoint)
  • set type argument is generalized to Type — while set, ticket, and map keys can only be comparable, current Michelson parser does not automatically converts comparable pairs, "or"s, and options into their "comparable twins", thus there can be an ambiguous situation.

@m-kus m-kus force-pushed the fix/michelson-instructions branch from dfea78e to 66f0344 Compare January 17, 2023 12:57
@m-kus m-kus force-pushed the fix/michelson-instructions branch from 66f0344 to c3188c4 Compare January 17, 2023 13:05
Copy link
Collaborator

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. The changes look good to me.

I noticed that this part of the code should contain more tests. Will add an issue to track it.

@RomarQ RomarQ merged commit 8885fac into airgap-it:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants