Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stack overflow when converting an address #17

Merged
merged 2 commits into from
Mar 5, 2023

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented Feb 28, 2023

Hey!

I found a stack overflow using String::from(address) with a contract address.

* Update tezos-core/src/types/encoded.rs
@fraidev fraidev force-pushed the fix_originated_address_to_string branch from 4ae7125 to e607e43 Compare February 28, 2023 02:20
@fraidev fraidev force-pushed the fix_originated_address_to_string branch from e607e43 to 20f6adb Compare February 28, 2023 02:29
@fraidev fraidev changed the title fix stack overflow when convert an address fix stack overflow when converting an address Mar 3, 2023
@RomarQ RomarQ changed the base branch from main to develop March 5, 2023 15:03
@RomarQ RomarQ self-requested a review March 5, 2023 15:03
@RomarQ
Copy link
Collaborator

RomarQ commented Mar 5, 2023

Good catch 👍

LGTM.

@RomarQ RomarQ merged commit 4972eca into airgap-it:develop Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants