Removes the tight coupling between the RPC client and Contract
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
develop to main
chore: bump version to 0.1.4
|
The changes make sense to me. The breaking changes should also not be a problem yet. @godenzim Let me know if you also agree with the purposed changes. |
RomarQ
approved these changes
May 14, 2023
godenzim
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found this library and started to play with it - very nice!
My application would require loose coupling between the RPC client and the
Contractstruct as I need to be able to easily switch RPC clients.Thus I've refactored
tezos-contractso that the user provides the RPC client as needed, rather than having it inside the relevant structs.What do you think?
P.S. I also added a .rustfmt.toml (empty) so that the formatter respects your formatting preferences, even when this project is a git submodule of another project.