Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerous automated fixes #37

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Conversation

emchristiansen
Copy link
Contributor

Each commit's message is the command that was run to generate that commit.

Note, neither cargo clippy --fix nor cargo +nightly fmt should change any semantics.

I did upgrade the packages using https://lib.rs/crates/cargo-edit, and everything still builds and all tests still pass.

BTW, you might want to add a commit-hook to automatically clippy --fix and fmt the code.

@RomarQ RomarQ changed the base branch from main to develop June 7, 2023 17:21
@RomarQ
Copy link
Collaborator

RomarQ commented Jun 7, 2023

Thanks for the contribution 👍

Will have a look at the changes later today.

@RomarQ RomarQ self-requested a review June 7, 2023 17:22
@RomarQ RomarQ force-pushed the eric-clippy branch 3 times, most recently from 4ec4cc6 to 818fed9 Compare June 7, 2023 21:12
@RomarQ
Copy link
Collaborator

RomarQ commented Jun 7, 2023

I moved the cargo upgrade commit to a different PR #38. Updating dependencies can be a nightmare sometimes, this needs some testing first.

@RomarQ
Copy link
Collaborator

RomarQ commented Jun 7, 2023

The remaining changes look good to me 👍

@RomarQ RomarQ merged commit 1f8e8ab into airgap-it:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants