Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static blake2b and OperationListListHash & BlockPayloadHash helpers #6

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

m-kus
Copy link
Contributor

@m-kus m-kus commented Dec 17, 2022

Hey! Here are two new changes:

  • first is making blake2b static (to avoid instantiating Crypto every time), instance method is kept for backward compatibility
  • second one is more specific, it is a port of generic merkle tree implementation used in Tezos protocol and its application for calculating root hashes in the block header (operation list list and block payload) — pls let me know if it is something you want to have in the SDK, or I can keep it outside

@RomarQ
Copy link
Collaborator

RomarQ commented Dec 19, 2022

Thank you again for the contribution.

I will try to review it later today or tomorrow.

@RomarQ
Copy link
Collaborator

RomarQ commented Jan 31, 2023

I have not forgotten about this PR. Just did not yet have the time to look into the specifics.
Hopefully will have a look next week.

@RomarQ RomarQ self-requested a review January 31, 2023 20:35
@m-kus
Copy link
Contributor Author

m-kus commented Jan 31, 2023

No worries :)
I think it requires some changes, similar to the coder: need to expose additional api rather than make internal mod public.
Will do tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants