Increase Production appengine instances to 2

[BenjaminSsempala]

Summary of Changes (What does this PR do?)

• Increase Prod AppEngine instances to 2

Summary by CodeRabbit

• Deployment Configuration
  • Updated production deployment workflow for improved application scaling
  • Increased minimum instances from 1 to 2
  • Added readiness checks to ensure robust application deployment and traffic handling

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the GitHub Actions workflow for deploying frontends to production, specifically focusing on the website2 deployment configuration. The changes involve increasing the minimum number of instances from 1 to 2 and introducing a comprehensive readiness_check section. This new configuration enhances deployment robustness by defining precise conditions for application readiness and traffic serving, ensuring more stable and reliable application startup.

Changes

File	Change Summary
.github/workflows/deploy-frontends-to-production.yml	- Increased minimum instances from 1 to 2 - Added readiness_check configuration with parameters for check intervals, timeouts, and thresholds

Sequence Diagram

sequenceDiagram
    participant Workflow
    participant App as Website2
    participant LoadBalancer
    
    Workflow->>App: Deploy with 2 min instances
    Workflow->>App: Apply Readiness Checks
    App-->>Workflow: Perform startup checks
    Workflow->>LoadBalancer: Validate App Readiness
    LoadBalancer-->>Workflow: Confirm Deployment

Loading

Possibly related PRs

• Adding Readiness checks and upscaling instances to handle Website deployments #2415: Introduces similar readiness checks and instance scaling modifications for website2 deployment

Suggested Reviewers

• OchiengPaul442
• Psalmz777
• Baalmart

Poem

🚀 Scaling up with grace and might,
Readiness checks burning bright,
Two instances, robust and strong,
Deployment workflow sings its song!
Reliability takes its flight 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/deploy-frontends-to-production.yml (1)

Line range hint 290-294: Well-configured readiness checks!

The readiness check configuration is well-balanced:

• 5-second check intervals with 4-second timeouts provide responsive health monitoring
• 2 failures/successes thresholds prevent flapping
• 30-minute app start timeout accommodates longer initialization needs

Consider monitoring the actual startup times in production to potentially reduce the app_start_timeout_sec if the application consistently starts much faster than 30 minutes.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4519ba and d39cac0.

📒 Files selected for processing (1)

• .github/workflows/deploy-frontends-to-production.yml (1 hunks)

🔇 Additional comments (1)

.github/workflows/deploy-frontends-to-production.yml (1)

282-282: LGTM! Increasing minimum instances improves availability.

The change from 1 to 2 minimum instances aligns with the PR objective and enhances system reliability by providing redundancy in production.