🌿 Fern Regeneration -- November 21, 2024 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![fern-api[bot]](https://avatars.githubusercontent.com/in/244756?s=60&v=4){kind=small}
kvindascr
reviewed
Nov 22, 2024
| @@ -57,11 +57,13 @@ def create( | |||
| skip_wait_session_ready = False | |||
| if hasattr(configuration, 'skip_wait_session_ready'): | |||
| skip_wait_session_ready = typing.cast(SessionConfig, configuration).skip_wait_session_ready | |||
| session_config_v1 = SessionConfigV1(**{k: v for k, v in configuration.__dict__.items() if k in SessionConfigV1.model_fields}) if configuration else None | |||
|
|
|||
| session_config_v1 = SessionConfigV1(**{k: v for k, v in configuration.__dict__.items() if k in SessionConfigV1.__fields__}) if configuration else None | |||
There was a problem hiding this comment.
For some unknown reason, the SessionConfigV1.model_fields is not properly compiling with mypy.
It was working fine, but now it doesn't compile.
I changed it to use the __fields__ attribute, which is deprecated, but it just calls the model_fields in the implementation.
kvindascr
reviewed
Nov 22, 2024
| @@ -168,12 +170,12 @@ async def main() -> None: | |||
| if hasattr(configuration, 'skip_wait_session_ready'): | |||
| skip_wait_session_ready = typing.cast(SessionConfig, configuration).skip_wait_session_ready | |||
|
|
|||
| session_config_v1 = SessionConfigV1(**{k: v for k, v in configuration.__dict__.items() if k in SessionConfigV1.model_fields}) if configuration else None | |||
|
|
|||
| session_config_v1 = SessionConfigV1(**{k: v for k, v in configuration.__dict__.items() if k in SessionConfigV1.__fields__}) if configuration else None | |||
There was a problem hiding this comment.
Same here about model_fields vs __fields__
kvindascr
reviewed
Nov 22, 2024
| @@ -11,7 +11,7 @@ keywords = [ | |||
| "browser", | |||
| "automation", | |||
| "agent", | |||
| "python", | |||
| "python" | |||
There was a problem hiding this comment.
pyproject.toml is not being generated properly with the updated fern python generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR regenerates code to match the latest API Definition.