-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aiaccel/hpo/apps/optimize.py . #414
Merged
Merged
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修正ありがとうございます. |
開発者会議メモ
|
BaseJobExecutor に submitted_job_count, finished_job_count を追加する形で改修しました。
|
…feature/fix_ci_failed
|
yoshipon
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while finished_job_count < config.n_trials
を通過した直後に実行中のジョブが終了した場合に、config.n_trials
よりも多くのジョブが生成されることがあるのが、原因だと思われますconfig.n_trials = 30
の時に、while finished_job_count < config.n_trials
を通過した直後に 30 個目のジョブが終了した場合、len(jobs.get_running_jobs())
の結果が 0 となるため、31 個目のジョブが生成されますclose #412