Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ShipLift Crate with Bollard as Docker SDK #161

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

samuchila
Copy link
Contributor

Currently docker's latest engine v25 is incompatible with ShipLift Crate. Moreover the maintenance for ShipLift has been stopped for a long time. This PR aims to replace ShipLift with the crate Bollard that is being maintained on a regular basis.

Fixes #160

Copy link
Contributor

@schrieveslaach schrieveslaach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very promising thanks a lot of tackling it. There are mostly some nitpicks but some things require some more thinking.

api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@schrieveslaach schrieveslaach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor commets, please check it out.

api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
api/src/infrastructure/docker.rs Outdated Show resolved Hide resolved
@samuchila samuchila force-pushed the docker-25-error-fix branch 2 times, most recently from b80caa0 to 795aaaa Compare February 28, 2024 13:31
@samuchila samuchila force-pushed the docker-25-error-fix branch from f41ff99 to 41e459e Compare April 23, 2024 13:57
Maintenance of ShipLift crate has been stopped and the latest docker
engine version 25 is incompatible with the crate. This will be replaced
with Bollard that is also an official docker SDK for rust. Additional
improvements to efficiency added.
@samuchila samuchila force-pushed the docker-25-error-fix branch from 41e459e to 8ba9092 Compare April 23, 2024 14:17
@schrieveslaach schrieveslaach merged commit 3cea941 into aixigo:master Apr 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PREvant is not Working with Docker Engine 25.0.1
2 participants