-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ShipLift Crate with Bollard as Docker SDK #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very promising thanks a lot of tackling it. There are mostly some nitpicks but some things require some more thinking.
d6223cd
to
9d397c7
Compare
11b6e38
to
630a727
Compare
aa6914b
to
ec39a2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor commets, please check it out.
b80caa0
to
795aaaa
Compare
f41ff99
to
41e459e
Compare
Maintenance of ShipLift crate has been stopped and the latest docker engine version 25 is incompatible with the crate. This will be replaced with Bollard that is also an official docker SDK for rust. Additional improvements to efficiency added.
41e459e
to
8ba9092
Compare
Currently docker's latest engine v25 is incompatible with ShipLift Crate. Moreover the maintenance for ShipLift has been stopped for a long time. This PR aims to replace ShipLift with the crate Bollard that is being maintained on a regular basis.
Fixes #160