Feat/user keybinds config externalized #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I'm over-encumbered with schoolwork right now, but I'll have a look at this when I find time. Thanks |
|
Take your time @ajayd-san, I am just excited to contribute for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ajayd-san,
I have shifted keybindings to the config file which can help in the issue #38, I have no idea how BubbleTea works. I can work on the keybindings page but I need some knowledge on BubbleTea(which I am currently working on)
I have tested the code and wrote one test case config in the config.test.go file.
Please let me know what you think about the PR