Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ac pr integ without any changes #3

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Commits on Oct 20, 2023

  1. Restore remote index shards with ExistingStoreRecoverySource after re…

    …store from remote state (opensearch-project#10665)
    
    * Restore remote index shards with ExistingStoreRecoverySource after restore from remote state
    
    Signed-off-by: bansvaru <[email protected]>
    linuxpi authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6641ef8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e12ab0f View commit details
    Browse the repository at this point in the history
  3. Fix spotless failure (opensearch-project#10782)

    Signed-off-by: Dhwanil Patel <[email protected]>
    dhwanilpatel authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    5093cc7 View commit details
    Browse the repository at this point in the history
  4. Add tracing instrumentation for indexing paths (opensearch-project#10273

    )
    
    * Add tracing instrumentation for indexing paths
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Fix failing tests and review changes
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Fix test failures due to Span not being properly closed
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Changes to spans in primary and replica actions
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Review comments fixes and refactoring
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Precommit auto-changes
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Add refresh policy as attribute
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Fix changelog entry
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Instrument primary/replica write in TransportWriteAction instead of TransportShardBulkAction
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Modify SpanBuilder
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * spotlessApply and precommit
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Change span names
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Pass Noop Tracer instead of injected tracer
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Reverting previous changes
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    * Remove tracer variable from TransportShardBulkAction
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    
    ---------
    
    Signed-off-by: Shreyansh Ray <[email protected]>
    rayshrey authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    e691df0 View commit details
    Browse the repository at this point in the history
  5. [Remote Store] Fix relocation failure due to transport receive timeout (

    opensearch-project#10761)
    
    * [Remote Store] Fix relocation failure due to transport receive timeout
    
    Signed-off-by: Ashish Singh <[email protected]>
    
    * Fix existing extended shardIdle for remote backed shards
    
    Signed-off-by: Ashish Singh <[email protected]>
    
    * Incorporate PR review comments
    
    Signed-off-by: Ashish Singh <[email protected]>
    
    ---------
    
    Signed-off-by: Ashish Singh <[email protected]>
    ashking94 authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    a1fde65 View commit details
    Browse the repository at this point in the history
  6. Update Github pull request template to have a task for inspecting fai…

    …ling checks (opensearch-project#10751)
    
    * Update Github pull request template to have a task for inspecting failing checks
    
    Signed-off-by: Andriy Redko <[email protected]>
    
    * Add failing builds troubleshooting section to CONTRIBUTING.md
    
    Signed-off-by: Andriy Redko <[email protected]>
    
    * Address review comments
    
    Signed-off-by: Andriy Redko <[email protected]>
    
    ---------
    
    Signed-off-by: Andriy Redko <[email protected]>
    reta authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ffe9371 View commit details
    Browse the repository at this point in the history
  7. Increase remote recovery thread pool size (opensearch-project#10750)

    The remote recovery thread pool does blocking I/O when downloading
    files, so the "half processor count max 10" was definitely too small.
    This can be shown by triggering recoveries on a node that is also doing
    segment replication, and the replication lag will increase due to
    contention on that thread pool. Some amount of contention is inevitable,
    but the change here to increase the download thread pool, and also limit
    the concurrent usage of that thread pool by any single
    recovery/replication to 25% of the threads does help.
    
    Long term, we can improve this even further by moving to fully async I/O
    to avoid blocking threads in the application on draining InputStreams.
    
    Signed-off-by: Andrew Ross <[email protected]>
    andrross authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    1e28738 View commit details
    Browse the repository at this point in the history
  8. Return unformatted Segment Replication metrics that take upload time …

    …into account for replication lag (opensearch-project#10723)
    
    * Return unformatted segrep metrics in stats
    
    Signed-off-by: Poojita Raj <[email protected]>
    
    * Take upload time into account for replication time lag
    
    Signed-off-by: Poojita Raj <[email protected]>
    
    * unformat segrep stats
    
    Signed-off-by: Poojita Raj <[email protected]>
    
    * remove unused field names
    
    Signed-off-by: Poojita Raj <[email protected]>
    
    ---------
    
    Signed-off-by: Poojita Raj <[email protected]>
    Poojita-Raj authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4f8bcff View commit details
    Browse the repository at this point in the history
  9. [Segment Replication] Fix Flaky test SegmentReplicationRelocationIT.t…

    …estPrimaryRelocation (opensearch-project#10701)
    
    * Add primary mode check before assserting on primary mode.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * remove unnecessary shardRouting check.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Add test logging.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Addressing comments on PR.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    ---------
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    Rishikesh1159 authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    1e9ec52 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. [Segment Replication] Add Segment Replication backpressure rejection …

    …stats to _nodes/stats (opensearch-project#10656)
    
    * Initial WIP for adding segrep backpressure to node stats.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Bind SegmentReplicarionStatsTracker in Node.java
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * remove additional segrep backpressure info from node stats
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * fix metric name in node stats
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Fix compile error.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Fix compile errors.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Address comments on PR.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Update java docs.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Address comments on PR and fix compile errors.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Address comments on PR.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    * Update unit test.
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    
    ---------
    
    Signed-off-by: Rishikesh1159 <[email protected]>
    Signed-off-by: Rishikesh Pasham <[email protected]>
    Rishikesh1159 authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    51626d0 View commit details
    Browse the repository at this point in the history
  2. Added changes for AdmissionControl Interceptor and AdmissionControlSe…

    …rvice for RateLimiting (opensearch-project#9286)
    
    * Changes for AdmissionControl Interceptor and AdmissionControlService for RateLimiting (opensearch-project#9286)
    
    Signed-off-by: Ajay Kumar Movva <[email protected]>
    ajaymovva authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    7c5a806 View commit details
    Browse the repository at this point in the history
  3. [Remote Store] Use time elapsed since last successful local refresh f…

    …or refresh lag (opensearch-project#10803)
    
    * [Remote Store] Use time elapsed since last successful local refresh for time lag
    
    Signed-off-by: Ashish Singh <[email protected]>
    
    * Incorporate PR review comments
    
    Signed-off-by: Ashish Singh <[email protected]>
    
    ---------
    
    Signed-off-by: Ashish Singh <[email protected]>
    ashking94 authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    14d4a63 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Added changes to integrade cpu AC to ResourceUsageCollector and Emit …

    …Stats
    
    Signed-off-by: Ajay Kumar Movva <[email protected]>
    Ajay Kumar Movva authored and bharath-techie committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    01e320f View commit details
    Browse the repository at this point in the history